-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RegExps support for Mjolnir's WordList protection #546
base: main
Are you sure you want to change the base?
Conversation
Testing (enabledRegExps=true)With this feature enabled I tested all of the following with this wordlist, it all worked fine:
Testing (enabledRegExps=false)Now to test it with this new feature disabled and the same wordlist, to ensure that all the previous functionality still works.
|
It's been stated that:
Just tested this out and nope, it seems fine. With this word list:
The entry that's While the truly blank entry at the end (when added after) seems to stop the WordList feature from working entirely. (Which is a separate issue this PR isn't meant to address really) |
This is a fix for #547 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The code looks good, but there's a couple things we need before we can merge:
- Sign off
- Unit/integration tests to prove the behaviour
If you run into issues with writing the tests, let us know in the Mjolnir room on Matrix and we'll try to help out.
I unfortunately don't have any time to create unit/integration tests for this. Maybe during the holiday season at the end of the year, but no promises. If someone could help create these tests to help get this patch through that would be great. |
What would unit tests for something like this look like? Just some manual test-cases? |
Well it did not take long for the spammers to side-step my word-list...
So here's a patch that actually allows you to enable regular expression support with Mjolnir's WordList protection! Making it substantially more powerful. 😎
I've tested this patch out and it appears to work flawlessly. Happy to revise it and re-test if needed.
Fixes #547