Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending ephemeral data to application services #2018

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Nov 28, 2024

As per MSC2409.

Fixes: #270

Pull Request Checklist

Preview: https://pr2018--matrix-spec-previews.netlify.app

As per MSC2409.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner November 28, 2024 16:28
Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh
Copy link
Contributor Author

zecakeh commented Nov 29, 2024

This would fix #270 if I'm not mistaken.

content/application-service-api.md Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from richvdh December 11, 2024 14:34
@zecakeh
Copy link
Contributor Author

zecakeh commented Dec 11, 2024

I believe that I applied all the suggestions/comments in the latest commit.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

changelogs/application_service/newsfragments/2018.feature Outdated Show resolved Hide resolved
data/api/application-service/transactions.yaml Outdated Show resolved Hide resolved
@richvdh richvdh changed the title Allow to send EDUs to application services Allow sending ephemeral data to application services Dec 11, 2024
@richvdh richvdh enabled auto-merge (squash) December 11, 2024 22:38
@richvdh richvdh merged commit 96b32f6 into matrix-org:main Dec 11, 2024
12 checks passed
@zecakeh zecakeh deleted the msc2409 branch December 11, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appservices should be receiving EDUs (read receipts, typing notifications, etc)
2 participants