Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop recommending deprecated CSP directive plugin-types in the content repository part of the spec #865

Open
dkasak opened this issue Jul 23, 2021 · 0 comments
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@dkasak
Copy link
Member

dkasak commented Jul 23, 2021

The plugin-types directive was removed from CSP, both in the web spec and in Chrome/Chromium. Firefox never implemented this.

Previously, a valid use for it was to specify plugin-types: application/pdf since object-src: 'none' disallowed rendering PDFs in some browsers using the browser's built-in PDF renderer (notably this was the case for Chrome). This is also why we started doing it and recommending it. Supposedly another workaround for this was to add rel="noreferrer" (see: https://secure.phabricator.com/T13112#237527).

Since support for this was removed, hopefully this shouldn't be a problem anymore. We should test whether it's still happening. If not, we should just switch to using/recommending object-src: none instead. If it's still happening, we should investigate whether there's another workaround we can use.

@dkasak dkasak added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit enhancement A suggestion for a relatively simple improvement to the protocol labels Jul 23, 2021
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Development

No branches or pull requests

1 participant