Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room identifier grammar: Is the localpart allowed to be empty? #611

Open
jplatte opened this issue Apr 17, 2020 · 5 comments
Open

Room identifier grammar: Is the localpart allowed to be empty? #611

jplatte opened this issue Apr 17, 2020 · 5 comments
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@jplatte
Copy link
Contributor

jplatte commented Apr 17, 2020

The spec says that room alias and group identifier's localparts must not be empty, but for room ids (and old-style event ids) this is not stated. Is !:matrix.org a valid room ID?

@turt2live turt2live added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit meta Something that is not a spec change/request and is not related to the build tools labels Apr 17, 2020
@aaronraimist
Copy link
Contributor

This could probably be a comment on https://github.com/matrix-org/matrix-doc/issues/667

@aaronraimist
Copy link
Contributor

aaronraimist commented Apr 18, 2020

Also MSC1597, which appears to be merged, clarified this and said it can't be empty. Why hasn't it landed in the spec? https://github.com/matrix-org/matrix-doc/blob/rav/proposals/id_grammar/proposals/1597-id-grammar.md

@turt2live
Copy link
Member

MSC1597 is still sitting in the implementation-needed pile: matrix-org/matrix-spec-proposals#1597

@jplatte
Copy link
Contributor Author

jplatte commented Sep 23, 2020

There are now both room IDs and room alias IDs with an empty localpart federated to matrix.org AFAIK. Looks like MSC1597 has to be closed (reverted?). I've allowed them in Ruma too.

@Cadair
Copy link
Contributor

Cadair commented Sep 24, 2020

@jplatte the state of matrix-org/matrix-spec-proposals#1597 has been changed to in review so I think it hasn't been agreed on. Also if something like that is accepted it would be like capitals in mxids, where a spec compliant implementation shouldn't make any more and the ones that exist have to continue to work.

@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@richvdh richvdh removed the meta Something that is not a spec change/request and is not related to the build tools label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Development

No branches or pull requests

5 participants