-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the power levels integer range #1169
Clarify the power levels integer range #1169
Conversation
279f850
to
f99eb40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking a look at this! My review is mostly nitpicky based on the surrounding spec, sorry.
1633425
to
10f9fc0
Compare
Signed-off-by: Johannes Becker <[email protected]>
10f9fc0
to
17b011b
Compare
Signed-off-by: Johannes Becker <[email protected]>
Signed-off-by: Johannes Becker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you add a changelog entry? A few words in 1169.clarification
in https://github.com/matrix-org/matrix-spec/tree/fad9feb80c804bc0c3d6c1cba2ee36f9be79daa2/changelogs/client_server/newsfragments will be fine.
Signed-off-by: Johannes Becker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry this took so long.
Signed-off-by: Johannes Becker <[email protected]>
To help with discussions which range of power levels are allowed. Without the clarification it's sometimes assumed that the max power level is 100.
As discussed on matrix: https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$GUmiy799UErZCQ-yi_WJS0kMNdafrjRlSYllW7fTKss?via=matrix.org&via=libera.chat&via=element.io
Signed-off-by: Johannes Becker [email protected]
Preview: https://pr1169--matrix-spec-previews.netlify.app