Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify if notifications are cleared by stream ordering or topological ordering #1167

Open
clokep opened this issue Jul 12, 2022 · 3 comments · May be fixed by matrix-org/matrix-spec-proposals#4033
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@clokep
Copy link
Member

clokep commented Jul 12, 2022

Link to problem area: https://spec.matrix.org/latest/client-server-api/#receiving-notifications

Issue:

It is not stated clearly which notifications get cleared when a read receipt is received, currently the spec reads:

When the user updates their read receipt (either by using the API or by sending an event), notifications prior to and including that event MUST be marked as read.

It is unclear if "prior to" refers to stream ordering or topological ordering. Synapse clears this based on stream ordering.

(Note that because of the inconsistency in /sync and /messages either could give odd results to a user.)

See conversation around https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$sb6NPRyuiu4wN7egyY8SJ6YoubvQqZvJSOlMFsTzVSE?via=matrix.org&via=libera.chat&via=element.io

@clokep clokep added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label Jul 12, 2022
@clokep
Copy link
Member Author

clokep commented Jul 12, 2022

@turt2live Thinks that MSC2285 specifies this properly.

@turt2live
Copy link
Member

kinda - I think MSC2285 has words which help clarify how this works rather than solves it.

@clokep
Copy link
Member Author

clokep commented May 18, 2023

kinda - I think MSC2285 has words which help clarify how this works rather than solves it.

The spec PR for this doesn't really seem to answer this question still, just uses terms like "before" and "after" to discuss events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants