Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3231: Token authenticated registration #3231
MSC3231: Token authenticated registration #3231
Changes from 13 commits
79c74c2
0a93e43
5b93cfd
1606dc4
5ba0996
aa8e896
84b9976
7e73525
22f1f93
32a9c01
80fc0ed
88edde6
2433c9f
5eb8a8b
79939f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems spurious: making something against the spec doesn't stop it from being a viable attack (if only...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add valid_until or invalid_since to show that the token was valid in the past but is not valid anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether tokens expire or not is up to the server, so some tokens might not expire, and it may not be easy for servers to store when a token becomes invalid.
The response could be changed so that the client can distinguish between tokens which are:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the usecase for distinguishing between "unknown to the server" and "known but invalid (were valid in the past)".
Also note that doing so consistently would require homeserver implementations to keep a record of all tokens ever created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the usecase. I don't think servers would be required to keep a record because if the token is unknown (maybe it was valid but is now deleted) then it can say so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also simple enough to add in a future extension so it shouldn't necessarily block the MSC. It does seem like it could be useful: servers presumably wouldn't be obliged to be 100% correct about what tokens are were valid and have never been valid.