crypto: UtdCause enum in reporting hooks and encryption event #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/utd-type-info
branch
6 times, most recently
from
aa002a6 to
ceb9fb1
Compare
andybalaam
force-pushed
the
andybalaam/utd-type-info
branch
from
ceb9fb1 to
519a4d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
=======================================
Coverage 83.62% 83.63%
=======================================
Files 241 242 +1
Lines 24926 24939 +13
=======================================
+ Hits 20844 20857 +13
Misses 4082 4082 ☔ View full report in Codecov by Sentry. |
andybalaam
force-pushed
the
andybalaam/utd-type-info
branch
from
519a4d1 to
b5e2eb6
Compare
7 tasks
Hywan
approved these changes
Apr 25, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to decorate messages we can't decrypt based on why we can't decrypt them. This PR detects the
membershipinfo provided if the server implements MSC4115 and provides that feedback to the client via theUtdCauseenum, which we expect to expand in the future.