Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC3061: Sharing room keys for past messages #580

Closed
Tracked by #39
BillCarsonFr opened this issue Apr 11, 2022 · 6 comments
Closed
Tracked by #39

Implement MSC3061: Sharing room keys for past messages #580

BillCarsonFr opened this issue Apr 11, 2022 · 6 comments

Comments

@BillCarsonFr
Copy link
Member

From element-ios created by manuroe: element-hq/element-ios#4947

As per MSC3061

See element-hq/element-android#4153

@jplatte
Copy link
Collaborator

jplatte commented Apr 28, 2022

I've created a Ruma issue for this as well: ruma/ruma#1104

@richvdh
Copy link
Member

richvdh commented Nov 16, 2022

When we do this, we should be sure not to repeat element-hq/element-web#23778 (sending out all of the room keys at once).

@poljar
Copy link
Contributor

poljar commented Nov 17, 2022

I'm aware of the flaws of the current approach, that is one of the reasons why this isn't yet implemented in the rust-sdk. A proper solution would need more time.

Thanks for reminding me.

@richvdh
Copy link
Member

richvdh commented Nov 17, 2022

@poljar if there are other flaws it might be good to link them here, so we can make sure that they are correctly addressed in whatever solution we use for the rust-sdk?

@poljar
Copy link
Contributor

poljar commented Nov 17, 2022

The main problems are:

  1. The authenticity of such keys can't be proven
  2. There's no way send over a batch of room keys, so m.forwarded_room_key is used
  3. Because of no 1 it's important to treat such keys in a special way, but no 2. makes it hard to do so.

What I proposed was to have a separate event type, which will separate the concepts and allow a batch of room keys to be sent over.

@dkasak
Copy link
Member

dkasak commented Nov 22, 2024

Given the reversion of MSC3061 following the vulnerability disclosure, closing this as not planned.

@dkasak dkasak closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants