-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider a generic schema migration framework for CryptoStore #3811
Comments
My concerns about this are:
|
For context, I am giving a real life example of migration. We have a techincal way to set the initial value of this flag by using An alternative could be to change the flag form a bool to an Option and set it to None. That way we could lazily migrate the data when we access them. But it feels bad to set something optional just because of migration? |
Currently, each
CryptoStore
implementation (IndexedDb and Sqlite) has its own migration system for updating the schema on each update. It has been suggested that we could instead implement a migration system at theCryptoStoreWrapper
level which can update the data objects without needing to implement the changes twice.The text was updated successfully, but these errors were encountered: