Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Rewire the Sticker button to be an Emoji Picker #3747

Merged
merged 6 commits into from
Jun 2, 2020
Merged

Rewire the Sticker button to be an Emoji Picker #3747

merged 6 commits into from
Jun 2, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 19, 2019 •
edited
Loading

Fixes element-hq/element-web#1107

Things left to do:

  • Figure out a nice way to expose stickers (likely, using a new icon) in the composer

image

@fti7
Copy link

fti7 commented Jan 14, 2020 •
edited
Loading

Any Updates here? 😄 Would be greate to have this merged!

@t3chguy
Copy link
Member Author

t3chguy commented Jan 14, 2020

Blocked on designer who is busy doing FOSDEM graphics and Cross Signing stuff :( we have to be patient

@jacotec
Copy link

jacotec commented Feb 7, 2020

Any updates here? The current emoji solution is a real mess and I'd also like to see that PR merged sooner than later. I quite often write messages in my iPhone instead in my opened Riot-Web just because I know I need some emojis ...

@t3chguy t3chguy mentioned this pull request Feb 17, 2020
Closed
@fti7
Copy link

fti7 commented Feb 22, 2020

Soon its March 2020.... any update from the Fosdem Designer? @lampholder please priotize such important UI stuff 😞

@nadonomy
Copy link
Contributor

nadonomy commented Mar 4, 2020

FYI all we've kicked off the design process on a new more extensible and scalable composer design for web, iOS & Android. We've opted for this as it means we can get things right in the long term.

Once we make good headway there, we'll run the design proposals through the major stakeholders per platform to figure out an execution plan, which will include very low hanging near-term tweaks (like this one!) that are aligned with long term direction.

@fti7
Copy link

fti7 commented Mar 16, 2020

@nadonomy do you have an rough estimation? Another 6 Months? 😞

@nadonomy
Copy link
Contributor

@nadonomy do you have an rough estimation? Another 6 Months? 😞

Snark aside— unfortunately the designer working on this has been ill for the last 2 weeks (since the day after they started on the designs). Totally undesirable delay, but the designs will be ready when they're ready.

@t3chguy t3chguy removed the blocked label May 29, 2020
t3chguy added 2 commits May 29, 2020 14:53
@t3chguy
Merge branches 'develop' and 't3chguy/emoji_picker_composer' of githu…
ccd0c95 
…b.com:matrix-org/matrix-react-sdk into t3chguy/emoji_picker_composer

� Conflicts:
�	src/components/views/rooms/MessageComposer.js
@t3chguy
Implement new design with new iconography
f40cfe4 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Copy link
Member Author

t3chguy commented May 29, 2020 •
edited
Loading

image

Latest ^

Build at http://riots.im/adhoc/emoji1/

@t3chguy t3chguy requested review from a team May 29, 2020 14:01
@aaronraimist
Copy link
Contributor

Looks pretty good! Any chance element-hq/element-web#6998 could get fixed here as well? The composer is starting to get lots of buttons.

@aaronraimist
Copy link
Contributor

Also in the tooltip "Show Stickers" has "stickers" capitalized but all of the other buttons there only have the first word capitalized

@t3chguy
Copy link
Member Author

t3chguy commented May 29, 2020

Looks pretty good! Any chance element-hq/element-web#6998 could get fixed here as well? The composer is starting to get lots of buttons.

Would love to, but that would mean waiting on product decision which would mean it'd miss next release so no.

Also in the tooltip "Show Stickers" has "stickers" capitalized but all of the other buttons there only have the first word capitalized

Fair but not a regression so don't want to fix it

@t3chguy
iterate PR
3020e39 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy requested a review from jryans June 2, 2020 12:48
jryans
jryans approved these changes Jun 2, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me!

@t3chguy
i18n
ef1d682 
Signed-off-by: Michael Telatynski <[email protected]>
nadonomy
nadonomy approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the caveat that we should fix the context menus spawning differently as a part of polishing the composer in the near future.

@t3chguy
Merge branches 'develop' and 't3chguy/emoji_picker_composer' of githu…
3fbfb62 
…b.com:matrix-org/matrix-react-sdk into t3chguy/emoji_picker_composer
@t3chguy t3chguy merged commit b50046f into develop Jun 2, 2020
@t3chguy t3chguy deleted the t3chguy/emoji_picker_composer branch June 2, 2020 13:13
@t3chguy t3chguy restored the t3chguy/emoji_picker_composer branch June 2, 2020 13:21
@t3chguy t3chguy mentioned this pull request Jun 2, 2020
Merged
@t3chguy t3chguy deleted the t3chguy/emoji_picker_composer branch June 2, 2020 13:30
@telmich
Copy link

telmich commented Jun 2, 2020

Ping @verysanghee - this is interesting for you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nadonomy nadonomy nadonomy approved these changes

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emoji picker UI
7 participants
@t3chguy @fti7 @jacotec @nadonomy @aaronraimist @telmich @jryans