Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tooltip: Use RovingAccessibleButton instead of RovingAccessibleTooltipButton #12539

Merged

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented May 15, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Part of element-hq/element-web#26762
RovingAccessibleTooltipButton was migrated to use AccessibleButton instead of AccessibleTooltipButton in a previous PR. There is no differences anymore between RovingAccessibleTooltipButton and RovingAccessibleButton.
So let's keep one.

@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 15, 2024
@florianduros florianduros force-pushed the florianduros/tooltip/RovingAccessibleTooltipButton branch from 763b0e4 to 1e3d61f Compare May 15, 2024 14:11
…essibleTooltipButton

# Conflicts:
#	src/components/views/elements/AccessibleButton.tsx
@florianduros florianduros added this pull request to the merge queue May 17, 2024
Merged via the queue into develop with commit 8f3c8b3 May 17, 2024
34 checks passed
@florianduros florianduros deleted the florianduros/tooltip/RovingAccessibleTooltipButton branch May 17, 2024 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants