This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 831
TAC: Close Release Announcement when TAC button is clicked #12475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Defect
Bugs, crashes, hangs, vulnerabilities, or other reported problems
label
Apr 30, 2024
t3chguy
reviewed
Apr 30, 2024
src/components/views/spaces/threads-activity-centre/ThreadsActivityCentre.tsx
Show resolved
Hide resolved
florianduros
force-pushed
the
florianduros/tac/ra-closing
branch
from
April 30, 2024 16:32
f10a718
to
50f35a2
Compare
florianduros
changed the title
Close Release Announcement when TAC button is opened
Close Release Announcement when TAC button is clicked
Apr 30, 2024
florianduros
changed the title
Close Release Announcement when TAC button is clicked
TAC: Close Release Announcement when TAC button is clicked
Apr 30, 2024
florianduros
added
X-Release-Blocker
This affects the current release cycle and must be solved for a release to happen
backport staging
Label to automatically backport PR to staging branch
labels
Apr 30, 2024
t3chguy
approved these changes
May 1, 2024
# Conflicts: # test/components/views/spaces/ThreadsActivityCentre-test.tsx
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-staging staging
# Navigate to the new working tree
cd .worktrees/backport-staging
# Create a new branch
git switch --create backport-12475-to-staging
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a3741b7794bc16ad75f392a44b1b07d5e50f432
# Push it to GitHub
git push --set-upstream origin backport-12475-to-staging
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-staging Then, create a pull request where the |
florianduros
added a commit
that referenced
this pull request
May 2, 2024
* Close RA when TAC button is clicked * Update snapshots (cherry picked from commit 6a3741b)
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport staging
Label to automatically backport PR to staging branch
T-Defect
Bugs, crashes, hangs, vulnerabilities, or other reported problems
X-Release-Blocker
This affects the current release cycle and must be solved for a release to happen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public
/exported
symbols have accurate TSDoc documentation.Fix part of element-hq/element-web#27412