Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to influence set_presence on /sync API calls #3578

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Add methods to influence set_presence on /sync API calls #3578

merged 3 commits into from
Jul 11, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 11, 2023 •
edited by github-actions bot
Loading

Here's what your changelog entry will look like:

✨ Features

  • Add methods to influence set_presence on /sync API calls (#3578).

@t3chguy t3chguy requested a review from a team as a code owner July 11, 2023 10:25
@t3chguy t3chguy requested review from andybalaam and dbkr July 11, 2023 10:25
@t3chguy t3chguy mentioned this pull request Jul 11, 2023
Merged
andybalaam
andybalaam requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but wanting more explanation for the TODO.

src/sliding-sync-sdk.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy requested a review from andybalaam July 11, 2023 12:44
andybalaam
andybalaam requested changes Jul 11, 2023
View reviewed changes
src/sliding-sync-sdk.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy requested review from andybalaam and removed request for dbkr July 11, 2023 13:08
@t3chguy t3chguy enabled auto-merge July 11, 2023 13:24
@t3chguy t3chguy added this pull request to the merge queue Jul 11, 2023
Merged via the queue into develop with commit f2471b6 Jul 11, 2023
@t3chguy t3chguy deleted the t3chguy/fix/20809 branch July 11, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @andybalaam