Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated TestClient with fetchMock #3550

Merged
merged 12 commits into from
Jul 25, 2023
Merged

Replace deprecated TestClient with fetchMock #3550

merged 12 commits into from
Jul 25, 2023

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jul 6, 2023 •
edited by github-actions bot
Loading

Replace use of deprecated TestClient and use fetchMock

Fixes https://github.com/vector-im/crypto-internal/issues/103

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner July 6, 2023 15:07
t3chguy
t3chguy reviewed Jul 6, 2023
View reviewed changes
src/crypto/backup.ts Outdated Show resolved Hide resolved
t3chguy
t3chguy reviewed Jul 6, 2023
View reviewed changes
src/crypto/index.ts Outdated Show resolved Hide resolved
richvdh
richvdh requested changes Jul 6, 2023
View reviewed changes
src/crypto/backup.ts Outdated Show resolved Hide resolved
src/crypto/backup.ts Outdated Show resolved Hide resolved
src/crypto/backup.ts Outdated Show resolved Hide resolved
spec/integ/crypto/megolm-backup.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/megolm-backup.spec.ts Outdated Show resolved Hide resolved
src/crypto/backup.ts Outdated Show resolved Hide resolved
spec/integ/crypto/megolm-backup.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/megolm-backup.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/megolm-backup.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/megolm-backup.spec.ts Outdated Show resolved Hide resolved
@BillCarsonFr BillCarsonFr changed the base branch from develop to valere/backup_clean_stop July 6, 2023 16:41
Base automatically changed from valere/backup_clean_stop to develop July 6, 2023 16:59
@BillCarsonFr BillCarsonFr added the T-Task Tasks for the team like planning label Jul 6, 2023
@BillCarsonFr BillCarsonFr requested a review from richvdh July 7, 2023 11:15
richvdh
richvdh reviewed Jul 7, 2023
View reviewed changes
spec/integ/crypto/megolm-backup.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/megolm-backup.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/megolm-backup.spec.ts Show resolved Hide resolved
@richvdh richvdh enabled auto-merge July 25, 2023 15:51
@richvdh richvdh added this pull request to the merge queue Jul 25, 2023
Merged via the queue into develop with commit 29b815b Jul 25, 2023
@richvdh richvdh deleted the valere/refactor_backup_test branch July 25, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy left review comments

@richvdh richvdh richvdh approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillCarsonFr @richvdh @t3chguy