Adjust fetchEditsWhereNeeded to use a clearer filter and async function #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
changed the title
andybalaam
changed the base branch from
develop
to
andybalaam/insert-edit-no-original
andybalaam
requested review from
germain-gg and
kerryarchibald
and removed request for
a team
andybalaam
force-pushed
the
andybalaam/adjust-filter-in-fetchEditsWhereNeeded
branch
from
38f3f6c to
09213ac
Compare
weeman1337
approved these changes
May 26, 2023
Good! Refactor with confidence 👍 |
germain-gg
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests already cover this logic - just refactoring it to be clearer.
Slight change: before this did all events that were either in thread or not a relation. In fact, we only do this for thread events, so we explicitly check for messages that are either in the thread or thread roots. This should have the same effect.
Part of element-hq/element-web#10954
This change is marked as an internal change (Task), so will not be included in the changelog.