Fix temporary call messages being handled without call #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
reviewed
Aug 9, 2021
Palid
force-pushed
the
palid/fix/signaling-state-errors
branch
from
f6f3a69 to
33d876a
Compare
Palid
changed the title
In cases where a rogue client, or just a simple bug, sends a temporary call message, like CallNegotiate the messages should just be discarded if there's no actual p2p connection created.
Palid
force-pushed
the
palid/fix/signaling-state-errors
branch
from
33d876a to
9fe05e7
Compare
Co-authored-by: Šimon Brandner <[email protected]>
Co-authored-by: Šimon Brandner <[email protected]>
Co-authored-by: Šimon Brandner <[email protected]>
SimonBrandner
approved these changes
Aug 11, 2021
dbkr
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Looking at call.js again, the most most likely cause of this was old calls ie. inited with initWithHangup(). It is worrying that we're seeing these spurious events at all and if it happened with a non-hung-up call we'd get very strange behaviour, but ok, let's see if we start getting this log message a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a rogue client, or just a simple bug, sends a temporary call message, like CallNegotiate the messages should just be discarded if there's no actual p2p connection created.