-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix-js-sdk uses unstable /relations
endpoint (and its unspecced original_event
field)
#2725
Comments
According to @turt2live:
Although it treats it as optional, it is unclear to me that it will do the correct thing if it is missing. |
This will regress element-hq/element-web#10200 or add an extra API call. |
@richvdh @turt2live Any thoughts on this? Are the solutions either:
|
sounds like an extra API call wouldn't be that bad? |
An extra API call is the least of that dialog's worries. If we put more effort into edits, we can always write an MSC. As an aside, is there a specific team we're expecting to action this? The js-sdk issue tracker tends to get, err, forgotten about. |
It feels like the EW platform team would be best placed to deal with it? I know EW isn't the only user of the js-sdk, but EW is by far the biggest driver for the js-sdk's development. (And, frankly, it'll be EW who get bitten hardest when Synapse stops grandfathering the unstable endpoint.) |
The WAT is very unlikely to have bandwidth to do this in this quarter, the quarter plan is already somewhat assuming we get more bodies, given this is used by threads, maybe the team working on threads? |
original_event
field from the /relations
response/relations
endpoint (and its unspecced original_event
field)
@justjanne has volunteered to take a look at switching this over to the stable endpoint. |
The
/relations
endpoint does not return anoriginal_event
field, yet the matrix-js-sdk uses it.We would like to remove support for this from Synapse in < 6 months. See matrix-org/synapse#12930 for more context.
The text was updated successfully, but these errors were encountered: