Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[process] How to introduce changes brought by strict: true #2127

Closed
ShadowJonathan opened this issue Jan 24, 2022 · 1 comment
Closed

[process] How to introduce changes brought by strict: true #2127

ShadowJonathan opened this issue Jan 24, 2022 · 1 comment

Comments

@ShadowJonathan
Copy link
Contributor

This is more of a meta-issue, but I want to work on #2116, I can propose PRs against the main branch, but likely every change i'll make (as i'll be adjusting public function signatures to better match their returns and correct behaviour) would be considered a "breaking" one.

Thus, I thought it'd be better if I would merge all of these individual changes against a "parking" branch, and then have that parking branch be merged into the main one in one go (and one major version change), with the changes pre-approved.

Any feedback on how to best approach this?

@turt2live
Copy link
Member

First we need to determine if it's a config change we even want, which is best discussed on the issue. Once we have more information about what the changes are then we can discuss how best to convert those to contributions.

I'm going to close this for now as it's essentially asking how to introduce a large change, but we don't know if we want that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants