Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require that server copy the room type when upgrading rooms #911

Closed
Mikaela opened this issue Oct 20, 2021 · 3 comments · Fixed by matrix-org/matrix-spec-proposals#3818
Closed

Require that server copy the room type when upgrading rooms #911

Mikaela opened this issue Oct 20, 2021 · 3 comments · Fixed by matrix-org/matrix-spec-proposals#3818
Labels
enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@Mikaela
Copy link

Mikaela commented Oct 20, 2021 •
edited
Loading

Suggestion

If I understand correctly, Element Web doesn't allow upgrading spaces as there is no mechanism for them to know that the homeserver will perform the operation correctly (without losing the information that the room is a space).
@Mikaela Mikaela added the enhancement A suggestion for a relatively simple improvement to the protocol label Oct 20, 2021
@turt2live turt2live changed the title Let clients know that upgrading spaces can be done safely Require that server copy the room type when upgrading rooms Oct 20, 2021
@Mikaela Mikaela mentioned this issue Jan 21, 2022
Draft
@Mikaela
Copy link
Author

Mikaela commented Jan 21, 2022

It looks like this may get resolved by matrix-org/matrix-spec-proposals#3385 and I think this also prevents upgrading matrix-org/matrix-spec-proposals#3588 rooms (or at least I am yet to get told otherwise in a week)

@clokep
Copy link
Member

clokep commented Jan 21, 2022 •
edited
Loading

Note that Synapse actually does this already for spaces: matrix-org/synapse#10774

@turt2live
Copy link
Member

ftr, the spec currently makes it an implementation detail for the field to carry over - open to suggestions (meaning MSCs) which discuss a different approach.

@Mikaela Mikaela mentioned this issue Feb 2, 2022
Closed
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 2, 2022
This was referenced May 18, 2022
Merged
Open
@anoadragon453 anoadragon453 mentioned this issue May 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSC3818: Copy room type on upgrade Mikaela/matrix-spec-proposals
3 participants
@clokep @Mikaela @turt2live