Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing format fields to m.room.message$m.notice schema. #2125

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Add missing format fields to m.room.message$m.notice schema. #2125

merged 1 commit into from
Jun 12, 2019

Conversation

jimmycuadra
Copy link
Contributor

The example event shows the format and formatted_body fields like the m.text message type, but these fields do not appear in the schema shown above the example.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Per the contributing guidelines can we get a sign off and changelog entry please?

@jimmycuadra
Copy link
Contributor Author

Done. It'd be useful to explain the changelog system a little better in the contributing guide. The fact that changelogs/client_server/newsfragments is empty in the repository is confusing. I had to look at another accepted pull request to see if I was doing it right, which adds some friction to contributing. Also, the contributing guide says that only the client-server spec is stable, which is no longer true!

@turt2live
Copy link
Member

Normally it does have other fragments in it, but after a release it's fairly empty and boring :(

The contributing guide definitely needs an update though, and not just because it says only the CS API is stable.

@turt2live turt2live merged commit a9297f9 into matrix-org:master Jun 12, 2019
@jimmycuadra jimmycuadra deleted the m.notice-format branch June 13, 2019 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants