Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick with { or } show up "=7B" and "=7D" #749

Closed
kroeckx opened this issue Apr 28, 2019 · 11 comments
Closed

Nick with { or } show up "=7B" and "=7D" #749

kroeckx opened this issue Apr 28, 2019 · 11 comments

Comments

@kroeckx
Copy link

kroeckx commented Apr 28, 2019

Someone with the nick {hoshi} on IRC shows up as _ircnet_=7bhoshi=7d in the room. Everything related to that nick is shown as that.

@Half-Shot
Copy link
Contributor

This is correct for the user_id, but not for the display name. Can you screenshot it / show me the users member state?

@kroeckx
Copy link
Author

kroeckx commented Apr 29, 2019

Message from the user:
message

Details of the user:
user

Is that what you're looking for?

@Mikaela
Copy link
Contributor

Mikaela commented May 6, 2019

Duplicate of #498?

@joepie91
Copy link

@Mikaela I'm getitng this issue on Freenode (see element-hq/element-web#9771), so it's probably a different issue (given that #498 explicitly mentions that Freenode is not affected).

@Half-Shot
Copy link
Contributor

This is a bit different. I believe it's because we now escape nicks for the purpose of shoving them in mxids (Matrix forbids a lot of characters, and we've been abusing this for years). My theory is that the displayname of IRC users is being wrongfully set to the localpart of their mxid.

@Half-Shot
Copy link
Contributor

This is fixed by #750

@mfiano
Copy link

mfiano commented May 23, 2019

This also seems to affect nicks containing pipe (|) characters. On the current Riot web version, this is still an issue.

@Mikaela
Copy link
Contributor

Mikaela commented Jun 27, 2019

@mfiano Have you seen #767 ? I wonder if you referred to it or it has gotten more broken since May the 23th.

@Ralith
Copy link

Ralith commented Jun 27, 2019

My theory is that the displayname of IRC users is being wrongfully set to the localpart of their mxid.

I've been seeing @freenode_=7b^_^=7d:matrix.org show up as =7b^_^=7d for months; note that this is not the localpart of the mxid.

@Half-Shot
Copy link
Contributor

FYI #768 hopes to disable the feature entirely until I have more time to make the whole IRC bridge cooperate with escaping.

@Half-Shot
Copy link
Contributor

Closing this PR, please use #744 for reporting issues of this type as they seem to all be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants