Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels on IRC that contain only matrix users should not be bridged to IRC #450

Open
kegsay opened this issue Jun 2, 2017 · 0 comments
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@kegsay
Copy link
Member

kegsay commented Jun 2, 2017

Some matrix users are creating channels with only matrix users in them, with no IRC presence at all, but they are still being bridged. This creates an unnecessary amount of traffic on IRC. It would be better for the bridge to part all the users (except for 1) in these scenarios, and then re-join the users when a real IRC user joins the channel. When the bridge is in the process of joining/parting users, it should be marked as a "desynced" room, as such it requires #449. To prevent this being an attack vector (whereby 1 malicious IRC user repeatedly joins/parts a bridged channel) the joins/parts should be adequately rate-limited. A suggestion of 4 joins/parts per second has been proposed as adequate, but this needs to be configurable on a per-server basis.

This has been formally requested by Freenode.

@kegsay kegsay added the bug label Jun 2, 2017
@justinbot justinbot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. and removed bug labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

4 participants