New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not retry membership on a 404 error #371

Merged

Half-Shot merged 2 commits into develop from hs/ignore-on-404-membership

Nov 4, 2021

Contributor

Half-Shot commented Nov 3, 2021 •

edited

Loading

Fixes #370

This usually means the room doesn't exist for ex: https://github.com/matrix-org/synapse/blob/c01bc5f43d1c7d0a25f397b542ced57894395519/synapse/handlers/room_member.py#L812.


          Do not retry membership on a 404 error

9edaa53

Half-Shot requested a review from a team

November 3, 2021 16:40


          changelog

046c695

jaller94 approved these changes

View reviewed changes

Contributor

jaller94 left a comment

Looks good.

I wonder if other HTTP errror codes like 400 BAD REQUEST should also return false. Other than 429 Too Many Requests none of the 4xx-codes seem recoverable.

Contributor Author

Half-Shot commented Nov 4, 2021

It's tricky, in the wild I've seen recoveries from generic M_UNKNOWN / 500 requests but you're right. Maybe this needs to check for explicit recoverable errors.

Half-Shot merged commit cc72c52 into develop

jaller94 deleted the hs/ignore-on-404-membership branch

November 4, 2021 09:58

Contributor

jaller94 commented Nov 4, 2021

Yeah, an HTTP 500 should be recoverable, but the 4xx-errors are almost all not recoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet