Add bridge_app_version metric #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
reviewed
Oct 13, 2021
src/components/prometheusmetrics.ts
Outdated
| help: "Version number of the bridge", | ||
| labels: ["version"], | ||
| }); | ||
| // This may change, so we need to refresh this. |
There was a problem hiding this comment.
This can change without the bridge restarting entirely??
There was a problem hiding this comment.
It's more that it's possible it may be set after this component has been loaded, .e.g. bridges that set the after loading metrics. Maybe it's leaning on the side of being too nice though, and we should make this immutable.
There was a problem hiding this comment.
I've changed this to only check the value once, and just warn in the docs that you should set the version before instantiating the bridge.
…ervice-bridge into hs/version-metric
tadzik
reviewed
Nov 3, 2021
src/utils/package-info.ts
Outdated
| return BridgeVersion; | ||
| } | ||
|
|
||
| console.log(getBridgeVersion(".")); |
There was a problem hiding this comment.
Is this intentionally left in?
There was a problem hiding this comment.
No, I am a stupid.
tadzik
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
bridge_app_versionmetric, which is already present in the IRC bridge (essentially this PR is upstreaming that code).