Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop config from run #345

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Drop config from run #345

merged 3 commits into from
Aug 3, 2021

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jul 29, 2021 •
edited
Loading

Fixes #262

This is also a breaking change.

@Half-Shot Half-Shot changed the title Hs/drop config from run Drop config from run Jul 29, 2021
@Half-Shot Half-Shot force-pushed the hs/drop-config-from-run branch from 3095b7d to a1e8f96 Compare July 29, 2021 14:46
@Half-Shot Half-Shot requested a review from a team July 29, 2021 14:46
tadzik
tadzik approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound.

@Half-Shot Half-Shot merged commit 134d8d5 into develop Aug 3, 2021
@Half-Shot Half-Shot self-assigned this Aug 3, 2021
@Half-Shot Half-Shot deleted the hs/drop-config-from-run branch May 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees

@Half-Shot Half-Shot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We don't seem to use the config argument for Bridge.run
2 participants
@Half-Shot @tadzik