Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check m.room.create event on room upgrade #330

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Check m.room.create event on room upgrade #330

merged 2 commits into from
Jun 2, 2021

Conversation

Half-Shot
Copy link
Contributor

The room upgrade code previously did not check to see if the new room ID referred back to the old room ID when traversing an upgrade.

@Half-Shot Half-Shot requested a review from a team June 2, 2021 11:59
benparsons
benparsons approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Half-Shot Half-Shot merged commit 70d0847 into develop Jun 2, 2021
@jaller94 jaller94 deleted the hs/fix-room-upgrade branch June 3, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benparsons benparsons benparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @benparsons