Use the matrix-bot-sdk for Matrix API calls #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bridge into hs/bot-sdk
jaller94
reviewed
Aug 9, 2021
jaller94
approved these changes
Aug 9, 2021
…bridge into hs/bot-sdk
Co-authored-by: Christian Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves us away from matrix-js-sdk to the matrix-bot-sdk. The advantages for which are:
This PR only aims to default to using the matrix-bot-sdk Intent/Client object by default for Matrix API calls (inside Intent and otherwise). It does NOT attempt to replace the appservice logic such as handling incoming events, which might be solved via a future PR.
Great pains have been taken to be API compatible, where intent functions have kept the same signature and compatibility code has been added in places. In addition, we've kept the ability to dynamically create matrix-js-sdk instances via
getClientas historically bridges use a mix of Intent and Client functions.However, upon merging this PR we will release a v3.0.0 of the library to make it an explicit upgrade choice by bridge developers.