Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queue metrics #283

Merged
merged 5 commits into from
Nov 23, 2020
Merged

Fix queue metrics #283

merged 5 commits into from
Nov 23, 2020

Conversation

Half-Shot
Copy link
Contributor

Fixes #282 by decreasing the value of pendingGauge regardless of the outcome of the membership action, as a call to queueMembership will increase it.

Also ensures we log a failure reason if either httpStatus or errcode exists on the exception.

@Half-Shot Half-Shot merged commit 127ff93 into develop Nov 23, 2020
@Half-Shot Half-Shot deleted the hs/fix-queue-metrics branch May 2, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bridge_membershipqueue_pending metric increases on each retry
1 participant
@Half-Shot