Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more intent calls #254

Merged
merged 6 commits into from
Oct 21, 2020
Merged

Add more intent calls #254

merged 6 commits into from
Oct 21, 2020

Conversation

Half-Shot
Copy link
Contributor

Fixes #136, #181

@Half-Shot Half-Shot requested a review from a team October 20, 2020 15:00
benparsons
benparsons approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, comments not blocking

src/components/state-lookup.ts Show resolved Hide resolved
src/components/intent.ts Show resolved Hide resolved
@Half-Shot Half-Shot merged commit 2ff23db into develop Oct 21, 2020
@Half-Shot Half-Shot deleted the hs/add-more-intent-calls branch May 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benparsons benparsons benparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy more js-sdk calls through intent
2 participants
@Half-Shot @benparsons