Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where defaults would be modified on validation #252

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix a bug where defaults would be modified on validation #252

merged 1 commit into from
Oct 15, 2020

Conversation

Half-Shot
Copy link
Contributor

This bug was causing config reloads to contain stale data

@Half-Shot Half-Shot requested a review from a team October 15, 2020 14:12
benparsons
benparsons approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Half-Shot Half-Shot merged commit 66156e7 into develop Oct 15, 2020
@Half-Shot Half-Shot deleted the hs/fix-validator-editing-default branch May 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benparsons benparsons benparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @benparsons