Fix issue where ghosts would not be registered #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/fix-registration-bug
branch
from
00009da to
169e735
Compare
|
Having looked again. I'm unsure if this is actually broken.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function tries to determine if a user should be /registered, and only calls the method if it thinks it needs to be done. We also want to force registration sometimes (e.g. for the bridge bot), and we also want to do extra steps for encryption enabled users. This causes a bit of gnarly logic to determine if we need to skip registration.
Previously, we were seeing that users who were NOT registered were not being registered due to encryption not being enabled and forceRegister being false.