Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return roomId on join #241

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Return roomId on join #241

merged 4 commits into from
Oct 5, 2020

Conversation

Half-Shot
Copy link
Contributor

Fix #239

@Half-Shot Half-Shot requested review from a team and jaller94 and removed request for a team October 3, 2020 22:35
jaller94
jaller94 approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Half-Shot Half-Shot merged commit 332442b into develop Oct 5, 2020
@Half-Shot Half-Shot deleted the hs/join-room_id branch May 2, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intent.join should return the room_id
2 participants
@Half-Shot @jaller94