Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weak event should allow state_key and unsigned to be optional #236

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Weak event should allow state_key and unsigned to be optional #236

merged 2 commits into from
Sep 28, 2020

Conversation

Half-Shot
Copy link
Contributor

Fixes #235

@Half-Shot Half-Shot requested a review from a team September 28, 2020 11:40
jaller94
jaller94 approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a code perspective.
Gotta brush up on what those properties mean in the Matrix Spec.

@Half-Shot Half-Shot merged commit ab1112d into develop Sep 28, 2020
@jaller94 jaller94 deleted the hs/weak-event branch September 28, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WeakEvent should not require state_key,unsigned to be defined
2 participants
@Half-Shot @jaller94