Port Bridge to Typescript #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for you to fix the tests. |
jaller94
reviewed
Aug 24, 2020
| onInvite(ev) { | ||
| if (!this._waitingForInvite.has(ev.room_id)) { | ||
| // eslint-disable-next-line camelcase | ||
| public async onInvite(ev: {room_id: string}) { |
There was a problem hiding this comment.
Why is this returning a boolean and what's the information this boolean carries?
There was a problem hiding this comment.
Have improved the JSDoc for the whole class.
Half-Shot
force-pushed
the
hs/port-bridge
branch
from
672f091 to
fd335d1
Compare
jaller94
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on the remaining TS PRs, so #209 and #210.
This PR ports the last file to Typescript and thus completes the Typescript project. After this, we can safely merge #199