Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Logging to Typescript #205

Merged
merged 9 commits into from
Aug 24, 2020
Merged

Port Logging to Typescript #205

merged 9 commits into from
Aug 24, 2020

Conversation

Half-Shot
Copy link
Contributor

No description provided.

@Half-Shot Half-Shot requested a review from a team August 21, 2020 10:18
@jaller94 jaller94 self-assigned this Aug 22, 2020
jaller94
jaller94 suggested changes Aug 22, 2020
View reviewed changes
src/components/logging.ts Outdated Show resolved Hide resolved
@jaller94 jaller94 removed their assignment Aug 22, 2020
@Half-Shot Half-Shot mentioned this pull request Aug 23, 2020
Merged
@Half-Shot
Update src/components/logging.ts
a754296 
Co-authored-by: Christian Paul <[email protected]>
@Half-Shot Half-Shot requested a review from jaller94 August 24, 2020 08:34
jaller94
jaller94 reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@Half-Shot Half-Shot merged commit f363ada into develop Aug 24, 2020
@jaller94 jaller94 deleted the hs/type-logging branch August 24, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @jaller94