Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Read receipts are not correctly updated in the room summary #527

Open
devjeff opened this issue Feb 7, 2020 · 1 comment
Open

Read receipts are not correctly updated in the room summary #527

devjeff opened this issue Feb 7, 2020 · 1 comment

Comments

@devjeff
Copy link

devjeff commented Feb 7, 2020

I think, there is a bug in the method "org.matrix.androidsdk.data.Room#handleReceiptData"

The read receipt event id is only updated if the receiptData is created by my user. According to the comment in the method and my understanding this is wrong. The setReadReceiptEventId method should be called in the opposite case, i. e. when the receiptData is coming from a different user. Thus, the if statement:

if (isUpdated && TextUtils.equals(mMyUserId, receiptData.userId))

must be changed to:

if (isUpdated && !TextUtils.equals(mMyUserId, receiptData.userId))

@AchrafAmil
Copy link

AchrafAmil commented May 11, 2020

Probably a sync issue.
I had a similar problem with handleReceiptData crashing on sync read receipts data cast.

AchrafAmil@e9e4a35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants