Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Cannot reject invites over federation #1743

Closed
fbushstone opened this issue Jan 30, 2021 · 3 comments · Fixed by #1918
Closed

Cannot reject invites over federation #1743

fbushstone opened this issue Jan 30, 2021 · 3 comments · Fixed by #1918
Assignees

Comments

@fbushstone
Copy link

fbushstone commented Jan 30, 2021

I'm on dendrite.matrix.org.

Description

I cannot reject invites

Steps to reproduce

  • Invite a user on a server running Dendrite
  • Revoke their invite
  • They will not be able to reject the invite

Edit: after doing a bit more testing only invites over federation have this issue. Inviting/disinviting other users on dendrite.matrix.org (for example) works great.
Important: After doing a few more tests, it looks like revoking their invite is a necessary step in these tests (rejecting invites before having them revoked seems to work just fine)

@kegsay kegsay added the bug label Feb 1, 2021
@fbushstone fbushstone changed the title Cannot reject invites Cannot reject invites over federation Feb 3, 2021
@andir
Copy link

andir commented Feb 14, 2021

Yeah, I can confirm the same. I just setup a dendrite instance yesterday. Joined a (custom) IRC gateway and have two "status channel" invites open that I can't reject but they are still showing up in my active invites.
The message I am getting is Failed to leave room "!cOdyQheypHfqXecCpX:server.org" through 1 server(s)

@kegsay
Copy link
Member

kegsay commented Jul 9, 2021

Related: #1828 #1727 #1400

Bizarrely though tests for this very thing pass :/

Test 169 Invited user can reject invite over federation... OK
Test 170 Invited user can reject invite over federation several times... OK
Test 171 Invited user can reject invite for empty room... OK
Test 172 Invited user can reject invite over federation for empty room... OK

@kegsay
Copy link
Member

kegsay commented Jul 12, 2021

However, these tests do NOT pass:

not ok 5 (expected fail) Inbound federation can receive invite and reject when remote replies with a 403 # TODO expected fail
not ok 6 (expected fail) Inbound federation can receive invite and reject when remote replies with a 500 # TODO expected fail
not ok 7 (expected fail) Inbound federation can receive invite and reject when remote is unreachable # TODO expected fail

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants