Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addplot type='scatter' support edgecolors and linewidths #405

Merged
merged 4 commits into from
Dec 14, 2021

Conversation

fxhuhn
Copy link
Contributor

@fxhuhn fxhuhn commented Jun 6, 2021

@@ -908,10 +908,13 @@ def _addplot_columns(panid,panels,ydata,apdict,xdates,config):
mark = apdict['marker']
color = apdict['color']
alpha = apdict['alpha']
edgecolors = apdict['edgecolors']
linewidths = apdict['linewidths']

if isinstance(mark,(list,tuple,np.ndarray)):
_mscatter(xdates,ydata,ax=ax,m=mark,s=size,color=color,alpha=alpha)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markus- Do you see any reason not to also add edgecolors=edgecolors, linewidths=linewidths to the call to _mscatter(). If you look at the code for mscatter() it will simply pass those kwargs down to scatter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DanielGoldfarb, never thought about it, but of course.

@DanielGoldfarb
Copy link
Collaborator

@fxhuhn
Markus, Hi. I'm finally getting around to processing the backlog of Pull Requests. This looks fine. Just thinking that maybe we should add edgecolors=edgecolors, linewidths=linewidths to the call to _mscatter() as well. Any thoughts about that?
Thanks. --Daniel

@DanielGoldfarb DanielGoldfarb merged commit 18fbd17 into matplotlib:master Dec 14, 2021
@DanielGoldfarb DanielGoldfarb changed the title adding edgecolors and linewidths make_addplot(...type='scatter'...) support edgecolors and linewidths` kwargs Dec 14, 2021
@DanielGoldfarb DanielGoldfarb changed the title make_addplot(...type='scatter'...) support edgecolors and linewidths` kwargs addplot type='scatter' support edgecolors and linewidths Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants