Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better information regarding memory usage by each plugin #6708

Closed
mgazdzik opened this issue Nov 21, 2014 · 7 comments
Closed

Provide better information regarding memory usage by each plugin #6708

mgazdzik opened this issue Nov 21, 2014 · 7 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@mgazdzik
Copy link
Contributor

In some cases archiving process is crashing because of reaching memory limit.
It's not always possible to just increase RAM limit for PHP process.
Therefore it would be a good to have reusable diagnostic tool, telling which plugin is depleting limit so it can be improved.

Goal of this ticket is to discuss such tool specification (possible usage, reported data, etc.) and implement it in core.

@mattab
Copy link
Member

mattab commented Nov 21, 2014

Also to note this particular problem occurs for period=year

2014-11-20 17:40:20 ERROR [2014-11-20 17:40:20] [a1988] Got invalid response from API request: index.php?module=API&method=API.get&idSite=1&period=year&date=last2&format=php&token_auth=x&trigger=archivephp. Response was 'PHP Fatal error: Allowed memory size of 4294967296 bytes exhausted (tried to allocate 8208 bytes) in /srv/piwik/piwik-2.8.3/core/DataTable.php on line 1156 '

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Nov 21, 2014
@mattab mattab added this to the Piwik 2.10.0 milestone Nov 21, 2014
@czolnowski
Copy link
Contributor

@mgazdzik I suppose that you need this information in archiving output. Since there is running API.get then might be difficult to gather information for every plugin. Would be enough to gather memory peak for every period & segment?

@mgazdzik
Copy link
Contributor Author

mgazdzik commented Dec 2, 2014

@czolnowski - why would it be difficult ? All plugin archivers are being triggered one after another in a loop, so I think it would be sufficent to store memory usage before and after archiving of single plugin and print it out. As for periods and segments - sure, this information could also be very useful. Maybe periods + segments could be on debug level, and per plugin on verbose ?

@mattab
Copy link
Member

mattab commented Dec 5, 2014

Hi @czolnowski if it's done please close that one 👍

@czolnowski
Copy link
Contributor

@mattab: I'm not sure how can I do this. There should be close button next to comment, but... I think that I don't have access to this repository.

@mattab
Copy link
Member

mattab commented Dec 6, 2014

@czolnowski you should now be able to close tickets! Welcome to the Piwik organisation.

@mattab mattab closed this as completed Dec 9, 2014
@mattab
Copy link
Member

mattab commented Dec 9, 2014

Hi @czolnowski I closed it as it looks fixed! 👍

@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants