Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: If development mode is enabled we should check whether action exists #6153

Closed
tsteur opened this issue Sep 7, 2014 · 0 comments
Closed

Menu: If development mode is enabled we should check whether action exists #6153

tsteur opened this issue Sep 7, 2014 · 0 comments
Assignees
@tsteur
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.7.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 7, 2014

In #6140 we have added three new methods to generate a URL for a menu item:

  • urlForDefaultAction()
  • urlForAction()
  • urlForModuleAction()

If development mode is enabled we should check whether the passed module and action is actually available, whether the action exists, whether the action is public and more. If any condition is not met a notification should be shown in the UI.
@tsteur tsteur added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Sep 7, 2014
@tsteur tsteur added this to the Short term milestone Sep 7, 2014
@tsteur tsteur closed this as completed in 5461654 Sep 7, 2014
@tsteur tsteur self-assigned this Sep 7, 2014
@tsteur tsteur modified the milestones: Piwik 2.7.0, Short term Sep 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
1 participant
@tsteur