Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User ID segment is available when visitor profile is disabled #21137

Closed
tsteur opened this issue Aug 9, 2023 · 0 comments · Fixed by #21218
Closed

User ID segment is available when visitor profile is disabled #21137

tsteur opened this issue Aug 9, 2023 · 0 comments · Fixed by #21218
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Privacy For issues that impact or improve the privacy.
Milestone
5.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Aug 9, 2023

When the visitor profile is disabled, we're already disabling the visitorId segment.

However, the userId segment is still enabled thus still allowing to identify individual users.

We would need to implement a similar logic as https://github.com/matomo-org/matomo/blob/5.0.0-b4/plugins/CoreHome/Columns/VisitorId.php#L45-L59 to disable the UserID segment when the visitor profile is disabled.
@tsteur tsteur added c: Privacy For issues that impact or improve the privacy. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Aug 9, 2023
@sgiehl sgiehl added this to the For Prioritization milestone Aug 9, 2023
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Aug 9, 2023
@sgiehl sgiehl modified the milestones: For Prioritization, 5.0.0 Sep 4, 2023
@sgiehl sgiehl self-assigned this Sep 4, 2023
@sgiehl sgiehl mentioned this issue Sep 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Privacy For issues that impact or improve the privacy.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Disable userId segment if visitor profile is disabled matomo-org/matomo
2 participants
@tsteur @sgiehl