Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove segment warning when no start date is set before release #16200

Closed
tsteur opened this issue Jul 9, 2020 · 0 comments · Fixed by #16512
Closed

Remove segment warning when no start date is set before release #16200

tsteur opened this issue Jul 9, 2020 · 0 comments · Fixed by #16512
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0-RC

Comments

@tsteur
Copy link
Member

tsteur commented Jul 9, 2020

See https://github.com/matomo-org/matomo/pull/16172/files#diff-c7ecf8d06820af52d6fae72297c6a9afR314

We should only trigger the warning if development mode is enabled.

Until the first few RCs we always show it so it's more visible. Alternatively, we could simply require a date to be always set and directly throw an exception in Segment::getSelectQuery() when no start or end date is set.

fyi @sgiehl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging a pull request may close this issue.

Log warning only in developer mode matomo-org/matomo
2 participants
@tsteur @sgiehl