Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segments for Download reports are partially broken #14180

Closed
sgiehl opened this issue Mar 11, 2019 · 1 comment
Closed

Segments for Download reports are partially broken #14180

sgiehl opened this issue Mar 11, 2019 · 1 comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.9.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Mar 11, 2019

regression from #14076

In Download urls reports the segment metadata is not always set correctly.
When viewing the report normal all segments for folders have a ^pageUrl= segment. Same applies for all rows when viewing the report flattened.

See build failure: https://travis-ci.org/matomo-org/matomo/jobs/504647208

ping @diosmosis
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Mar 11, 2019
@sgiehl sgiehl added this to the 3.9.0 milestone Mar 11, 2019
@diosmosis
Copy link
Member

@sgiehl fixed in my fix-build2 branch. There's one failing test left before it can be merged.

@diosmosis diosmosis mentioned this issue Mar 12, 2019
Merged
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.9.0
Development

No branches or pull requests
3 participants
@diosmosis @mattab @sgiehl