-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Variables in 4.x #204
Comments
If you want to review the code, I've created a pull request here: #205 |
Hi @zantoku, thanks for your information here and the pull request. I will check it out and see how it fits into the SDK. Generally I am not sure how deprecated features should be integrated into the SDK. As far as I see there are a few options.
I think 2 is better than 1, since it shows new users that there is a "better" way to achieve the same. 4 Could be a bit complicated for users that need the same features. What do you think? |
Hi @brototyp, seeing as how all the work for option 2 is already done, I'd appreciate if we could proceed with that! :) Do you want me to extend the pull request with deprecation annotations? |
Hi @zantoku, I am fine with option two. Can you add the deprecation annotations and a paragraph in the readme? |
This got implemented and merged in #223. It is be part of the 5.0.0-beta1 release. |
We have a "legacy" project that relies on the use of Custom Variables. We can't readily change to Custom Dimensions, so until now we've been forced to stay on the old 3.x version of the SDK.
However, we really want to move to the 4.x branch of the SDK so we don't run into a situation where the old SDK breaks for some reason and we're left unsupported.
So what I've done is add support for Custom Variables (and improve the ObjC-interop a little), largely following the implementation pattern for Custom Dimensions. Can we contribute the code to the project?
The text was updated successfully, but these errors were encountered: