Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Python3 support is a serious issue #257

Closed
udf2457 opened this issue Feb 15, 2020 · 11 comments
Closed

Lack of Python3 support is a serious issue #257

udf2457 opened this issue Feb 15, 2020 · 11 comments

Comments

@udf2457
Copy link

udf2457 commented Feb 15, 2020

python/devguide#344
https://www.python.org/dev/peps/pep-0373/#possible-features-for-2-7

As per the above links, Python2, is now fully dead, as per a quote from the above:

no updates, not even source-only security patches, after that date

Issues #3 & #242 seem to be an eternal work-in-progress.

This really needs to be prioritised as a major issue that needs addressing !

P.S. Don't ask me to contribute code, I can't code in Python, at all, not even at newbie level. I am just a Matomo user that doesn't want to be forced to drop Matomo due to reliance on obsolete, unsupported version of Python.

@Findus23
Copy link
Member

I am fully aware of the end of life of Python2, but #242 isn't a work-in-progress. It is mostly finished but depends on more people testing it.
There are about 60 options that can be combined for all kinds of rare use cases and I don't have the ability to test if all of them still work as before.

@udf2457
Copy link
Author

udf2457 commented Feb 16, 2020

Afraid I only use --url --auth-user --auth-password --enable-http-errors --enable-http-redirects --enable-static --enable-bots --recorders --log-format-name=nginx_json

Maybe you can release two versions ? Simplified one for those of us who just want a simple life (quick and easy integration with NGINX) and an advanced one (which is initially released with a big fat disclaimer at the top saying "60 currently untested monsters lurk within")

@mattab
Copy link
Member

mattab commented Feb 18, 2020

we won't release two versions @udf2457 - but be great if you already help test #242 and leave your comment/update there 👌

@udf2457
Copy link
Author

udf2457 commented Jun 4, 2020

Are we anywhere nearer getting rid of Python 2 once and for all ? I'm on the verge of giving up and dumping Matomo for an alternative log analysis tool.

At the present time, Matomo is the only piece of code in our entire infrastrucure that still uses Python 2. We see no reason to continue "supporting" such obsolescene throuh un-necessary installation of Python 2.

@Findus23
Copy link
Member

Findus23 commented Jun 4, 2020

@udf2457 The python3 support is already "finished" since last year in #242. Did you already test if it works correctly in your environment? If enough people report back, it should be fine to release it together with Matomo 4 this year.

You can get the python script from that branch here: https://github.com/Findus23/piwik-log-analytics/blob/python3-2019/import_logs.py

@udf2457
Copy link
Author

udf2457 commented Jun 4, 2020

Its not finished if it's not tested.

I suggested earlier this year that if testing is a problem, you should release a simplified version that didn't require god knows hows how many combinations of testing to test for all 60 flags or whatever stupidity of number of options flags are in the full version.

I'm leaving the Matomo community and going elsewhere.

@sgiehl
Copy link
Member

sgiehl commented Jun 4, 2020

I would suggest to drop the support for Python 2 with release of Matomo 4. That means we could maybe already merge the changes of #242 into 4.x-dev branch and check if at least all Matomo tests are running correctly with Python 3 on travis.

@mattab is python 3 support considered as part of Matomo 4 or should that be available for Matomo 3 as well?

@Findus23
Copy link
Member

Findus23 commented Jun 4, 2020

Its not finished if it's not tested.

Correct. I'd therefore propose to also announce a beta release together with the first Matomo 4 beta release.

@mattab
Copy link
Member

mattab commented Jun 12, 2020

is python 3 support considered as part of Matomo 4 or should that be available for Matomo 3 as well?

I'm not too familiar with availability of Python 3 on older LTS systems, but in general it makes sense to drop support for python2 and only support one codebase at a time (python 3). So sounds good to me to proceed with beta testing the python3 version as part of Matomo 4 👍

@jreynder
Copy link

You can use a docker python 2 container (as I do).
docker run -it --rm --name import_logs -v /var/www/:/var/www/:ro -v /var/run/mysqld/:/run/mysqld/ -v /var/log/:/var/log/:ro python:2-alpine python /var/www/matomo/misc/log-analytics/import_logs.py --url=http://your.matomo.server/ --idsite=1 --recorders=4 --token-auth=your.token /var/log/nginx/your.access.log

@sgiehl sgiehl added this to the Current sprint milestone Aug 26, 2020
@sgiehl
Copy link
Member

sgiehl commented Aug 26, 2020

Python 3 support will be part of Matomo 4.

@sgiehl sgiehl closed this as completed Aug 26, 2020
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants