Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESM #427

Merged
merged 4 commits into from
Aug 14, 2021
Merged

Support ESM #427

merged 4 commits into from
Aug 14, 2021

Conversation

PabloSzx
Copy link
Contributor

@PabloSzx PabloSzx commented Aug 13, 2021

graphql-middleware should support ESM 👍, especially since it will be kept for the next version of graphql-yoga

The recent blog post where I talked about it: https://the-guild.dev/blog/support-nodejs-esm

  • Using bob-esbuild that uses rollup + esbuild
  • Simple conversion from yarn to pnpm, specially needed for publishConfig.directory, check TypeScript > support for exports in blog post, since this library is not using changesets, which also supports it

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #427 (223a0f9) into master (36fee83) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #427   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          197       195    -2     
  Branches        41        41           
=========================================
- Hits           197       195    -2     
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fee83...223a0f9. Read the comment docs.

@maticzav maticzav merged commit fdd6417 into maticzav:master Aug 14, 2021
@PabloSzx
Copy link
Contributor Author

@maticzav
image

@github-actions
Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@PabloSzx
Copy link
Contributor Author

oh, it was already released as minor, it should be fine anyways 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants