Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we get rid of fetch polyfill ? #10

Closed
shahbhavir opened this issue Oct 11, 2018 · 0 comments
Closed

Should we get rid of fetch polyfill ? #10

shahbhavir opened this issue Oct 11, 2018 · 0 comments
Labels
optimize Optimize library (by reducing bundle size, etc)

Comments

@shahbhavir
Copy link
Contributor

shahbhavir commented Oct 11, 2018 •
edited
Loading

Remove isomorphic-fetch from the codebase, and we should convey message clearly to library users (developers).

If the environment doesn't have built-in support for fetch, do include a polyfill.

Few fetch polyfill libraries: github/fetch, isomorphic-fetch

Find the relevant discussion here: w3ctag/polyfills#6
@shahbhavir shahbhavir added the optimize Optimize library (by reducing bundle size, etc) label Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimize Optimize library (by reducing bundle size, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdkanani @shahbhavir