Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing all addresses to string instead of bytes in new-heimdall #413

Closed
ssandeep opened this issue Nov 19, 2020 · 3 comments
Closed

Changing all addresses to string instead of bytes in new-heimdall #413

ssandeep opened this issue Nov 19, 2020 · 3 comments
Assignees
@ssandeep
Milestone
Feb 2021 Sprint 2

Comments

@ssandeep
Copy link
Contributor

Ref: cosmos/cosmos-sdk#7242
@ssandeep
Copy link
Contributor Author

We need to stick to either lower or upper case for addresses
cc: @anilcse @ptsayli @mankenavenkatesh @jdkanani

@jdkanani
Copy link
Contributor

Let's use lowercase address everywhere. All msg.go will use the same lowercase addresses. CLI and rest API handlers will convert to lowercase from the given address input.

@anilcse
Copy link
Contributor

anilcse commented Nov 19, 2020

Yes, let's use lowercase addresses

@ssandeep ssandeep assigned ssandeep and unassigned ptsayli Jan 29, 2021
@ssandeep ssandeep added this to the Feb 2021 Sprint 2 milestone Jan 29, 2021
@jdkanani jdkanani mentioned this issue Jan 29, 2021
Closed
@ssandeep ssandeep removed the backlog label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssandeep ssandeep

Labels
None yet
Projects
None yet
Milestone
Feb 2021 Sprint 2
Development

No branches or pull requests
4 participants
@ssandeep @jdkanani @anilcse @ptsayli