Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popout group flow error #797

Closed
mathuo opened this issue Dec 21, 2024 · 4 comments · Fixed by #798 or #824
Closed

Popout group flow error #797

mathuo opened this issue Dec 21, 2024 · 4 comments · Fixed by #798 or #824

Comments

@mathuo
Copy link
Owner

mathuo commented Dec 21, 2024

          This is half-fixed as of 2.1.1 - 

When a panel or group goes from grid -> popout -> floating, Dockview used to crash. Now, dockview creates the floating group as expected. Nice!

But when a panel or group goes from floating -> popout -> floating, Dockview used to make a (bugged) empty floating group. Now Dockview throws an error, and the panel is closed.

Video attached. I can move this to a new issue if you'd prefer!

dockview.mp4

Originally posted by @zaxer2 in #782 (comment)

@mathuo mathuo linked a pull request Dec 21, 2024 that will close this issue
@mathuo
Copy link
Owner Author

mathuo commented Dec 21, 2024

@zaxer2 This should be fixed in 2.1.4. Please do let me know if that works for you

@zaxer2
Copy link
Contributor

zaxer2 commented Jan 3, 2025

@zaxer2 This should be fixed in 2.1.4. Please do let me know if that works for you

This fix looks great for Panels, individual panels are moving smooth as butter.

There is one remaining spot of weirdness regarding Groups in particular: if you make a Group into a Floating group -> then into a Popout group -> then back into a Floating group, Dockview still crashes.

All other behavior seems normal though, as far as I can tell! 👍

Screen.Recording.2025-01-03.143258.mp4

@mathuo
Copy link
Owner Author

mathuo commented Jan 9, 2025

Amazing - I believe I've found this issue too. I will raise a PR and aim to release once tested. Thanks for all the work in finding this issues!

@mathuo mathuo linked a pull request Jan 9, 2025 that will close this issue
@zaxer2
Copy link
Contributor

zaxer2 commented Jan 9, 2025

Of course! It's all stuff that's popped up naturally in my use case- documented to the best of my ability. Thanks for creating & maintaining such a useful tool! I'm awed by its versatility :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants